Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mrkaye97
approved these changes
Feb 2, 2026
|
📝 Documentation updates detected! New suggestion: Update terminology from "step run" to "task run" for consistency Tip: Add or adjust Promptless's style guide in Agent Knowledge Base ✍️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the clarity of cancellation-related log messages in the TypeScript SDK. Previously, when a workflow was cancelled, the SDK would log misleading error messages like "Could not wait for step run to finish: Cancelled by worker" at the
errorlevel, causing confusion since cancellation is expected behavior, not a failure.This PR:
errortodebuglevelType of change
What's Changed
handleStartStepRuncatch block to log cancellations atdebuglevel while keeping real failures aterrorlevelhandleCancelStepRuncatch block to usedebuglevel since the promise rejection is expected during cancellationBefore:
After: