Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
grutt
approved these changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the Python SDK version to 1.22.16, incorporating two key improvements: migrating from the deprecated asyncio.iscoroutinefunction to inspect.iscoroutinefunction, and enhancing REST client error diagnostics with more comprehensive exception handling and contextual information.
Changes:
- Migrated three functions in
types.pyto useinspect.iscoroutinefunctioninstead of the deprecatedasyncio.iscoroutinefunction - Expanded REST client exception handling to catch SSL, connection timeout, read timeout, max retry, new connection, and protocol errors, with enriched error messages including method, URL, and timeout information
- Added a new patch function to automatically apply REST client error diagnostic improvements to generated code
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdks/python/pyproject.toml | Version bump from 1.22.15 to 1.22.16 |
| sdks/python/hatchet_sdk/runnables/types.py | Added inspect import and migrated three type guard functions to use inspect.iscoroutinefunction |
| sdks/python/hatchet_sdk/clients/rest/rest.py | Enhanced exception handling to catch multiple urllib3 transport errors and provide detailed diagnostic context |
| sdks/python/apply_patches.py | Added patch_rest_error_diagnostics function to apply REST client improvements via regex-based patching |
| sdks/python/CHANGELOG.md | Documented the changes for version 1.22.16 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merges some small improvements + bug fixes from #2942 and #2933
Type of change