Fix: Check uuid.Nil when creating or groups too#2958
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mnafees
approved these changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the SDK sends uuid.Nil (the zero-value UUID) by default for uuid.UUID typed fields instead of empty strings. The code now properly checks for both empty strings and nil UUIDs when determining whether to generate a new OR group ID.
Changes:
- Updated OR group ID validation to check for both empty strings and
uuid.Nil.String()before generating new IDs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forgot the SDK will send
uuid.Nilby default because it'suuid.UUIDnot*uuid.UUID🤦Type of change