Mark old v0 and generics-based v1 Go SDK methods as deprecated#2962
Mark old v0 and generics-based v1 Go SDK methods as deprecated#2962
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR marks old v0 and generics-based v1 Go SDK methods as deprecated, directing users to migrate to the new Go SDK at github.com/hatchet-dev/hatchet/sdks/go. The deprecation comments follow a consistent pattern distinguishing between three categories: legacy v0 workflow definition system, old generics-based v1 SDK, and internal types/methods used by the new SDK.
Changes:
- Added deprecation notices to all v0 workflow definition types and functions (Workflow, WorkflowJob, WorkflowStep, trigger converters, etc.)
- Added deprecation notices to all v1 generics-based SDK types and functions (WorkflowDeclaration, TaskDeclaration, Worker, feature clients, etc.)
- Added deprecation notices to internal types and methods that are used by the new SDK but shouldn't be used directly by users
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/worker/workflow.go | Deprecated v0 workflow trigger types and workflow structure types |
| pkg/worker/worker.go | Deprecated internal Worker types and v0 service methods |
| pkg/worker/service.go | Deprecated v0 Service type and workflow registration methods |
| pkg/worker/middleware.go | Deprecated internal MiddlewareFunc type |
| pkg/v1/workflow/declaration.go | Deprecated v1 generics-based workflow declaration types and added package-level deprecation |
| pkg/v1/worker/worker.go | Deprecated v1 Worker interface and implementation types with package-level deprecation |
| pkg/v1/task/task.go | Deprecated v1 task declaration types with package-level deprecation |
| pkg/v1/features/workflows.go | Deprecated WorkflowsClient interface and constructor |
| pkg/v1/features/workers.go | Deprecated WorkersClient interface and constructor |
| pkg/v1/features/webhooks.go | Deprecated webhook-related types and client interface |
| pkg/v1/features/tenant.go | Deprecated TenantClient interface and constructor |
| pkg/v1/features/schedules.go | Deprecated SchedulesClient interface and related types |
| pkg/v1/features/runs.go | Deprecated RunsClient interface and constructor |
| pkg/v1/features/ratelimits.go | Deprecated RateLimitsClient interface and related types |
| pkg/v1/features/metrics.go | Deprecated MetricsClient interface with package-level deprecation |
| pkg/v1/features/filters.go | Deprecated FiltersClient interface and constructor |
| pkg/v1/features/crons.go | Deprecated CronsClient interface and related types/functions |
| pkg/v1/features/cel.go | Deprecated CELClient interface and related types |
| pkg/v1/factory/workflow_factory.go | Deprecated NewWorkflow factory function with package-level deprecation |
| pkg/v1/factory/task_factory.go | Deprecated NewTask factory function |
| pkg/v1/factory/durable_factory.go | Deprecated NewDurableTask factory function |
| pkg/v1/config.go | Deprecated v1 Config and TLSConfig types |
| pkg/v1/client.go | Deprecated HatchetClient interface and constructor with package-level deprecation |
| pkg/client/types/file.go | Deprecated v0 workflow file types and parsing functions |
| pkg/client/client.go | Deprecated internal Client interface and related types |
| pkg/client/admin.go | Deprecated PutWorkflow and PutWorkflowV1 methods on AdminClient |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📝 Documentation updates detected! Updated existing suggestion: Update migration guides to reflect V0 and V1 Generics SDK deprecation Tip: Connect Jira, Linear, Confluence, and more in Integrations to enrich suggestion quality 🔗 |
|
📝 Documentation updates detected! New suggestion: Add V0 and V1 Generics SDK deprecation notices to Go migration guide Tip: Sort by Shortest Review in the Dashboard to find quick wins ⚡ |
Description
Marks old v0 and generics-based v1 Go SDK methods as deprecated.
Type of change