Skip to content

Improve error message when failing to send task to worker#3350

Merged
juliusgeo merged 3 commits into
mainfrom
update_worker_send_timeout_error_msg
Mar 22, 2026
Merged

Improve error message when failing to send task to worker#3350
juliusgeo merged 3 commits into
mainfrom
update_worker_send_timeout_error_msg

Conversation

@juliusgeo
Copy link
Copy Markdown
Contributor

@juliusgeo juliusgeo commented Mar 20, 2026

Description

Improves the error message surrounding tasks failing to be dispatched to the worker with helpful advice for the user. This goes along with the recent change from using a fixed backlog of tasks being dispatched, to failing when a task times out attempting to acquire the sender lock #3290.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change (pure documentation change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking changes to code which doesn't change any behaviour)
  • CI (any automation pipeline changes)
  • Chore (changes which are not directly related to any business logic)
  • Test changes (add, refactor, improve or change a test)
  • This change requires a documentation update

What's Changed

  • Add a list of tasks or features here...

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hatchet-docs Ready Ready Preview, Comment Mar 22, 2026 4:17pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2026

Benchmark results

goos: linux
goarch: amd64
pkg: github.com/hatchet-dev/hatchet/internal/services/dispatcher
cpu: AMD Ryzen 9 7950X3D 16-Core Processor          
                  │ /tmp/old.txt  │          /tmp/new.txt          │
                  │    sec/op     │    sec/op      vs base         │
LockAcquisition-8   637.8n ± 110%   684.5n ± 103%  ~ (p=0.240 n=6)

                  │ /tmp/old.txt │         /tmp/new.txt          │
                  │     B/op     │     B/op      vs base         │
LockAcquisition-8   332.5 ± 150%   334.5 ± 137%  ~ (p=1.000 n=6)

                  │ /tmp/old.txt │         /tmp/new.txt         │
                  │  allocs/op   │  allocs/op   vs base         │
LockAcquisition-8    4.000 ± 50%   4.000 ± 25%  ~ (p=1.000 n=6)

Compared against main (db140b7)

@promptless-for-oss
Copy link
Copy Markdown

📝 Documentation updates detected!

Updated existing suggestion: Update flow control env var from backlog size to lock acquisition timeout


Tip: Filter the Dashboard by labels or assignees to focus on what matters to you 🔎

@mrkaye97
Copy link
Copy Markdown
Contributor

mrkaye97 commented Mar 21, 2026

how does this look when it renders on the FE when it happens?

@juliusgeo
Copy link
Copy Markdown
Contributor Author

@mrkaye97 Looks like this!
image

@mrkaye97
Copy link
Copy Markdown
Contributor

@mrkaye97 Looks like this! image

Thanks! Does it also show up in the activity tab inline with the failure event? if not (or if it does but looks fine), then this is great 👍

@juliusgeo
Copy link
Copy Markdown
Contributor Author

@mrkaye97 It does show up inline (kinda), but you have to click on view error first
image

@juliusgeo juliusgeo merged commit a962a5d into main Mar 22, 2026
51 checks passed
@juliusgeo juliusgeo deleted the update_worker_send_timeout_error_msg branch March 22, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants