Fix: empty parent task external id on olap dags and runs#3605
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect propagation of ParentTaskExternalID when creating DAG payloads, which previously caused “empty UUID” parent task external IDs to be written into OLAP for root DAGs/runs.
Changes:
- Stop wrapping
ParentTaskExternalIDin a non-nil pointer to a zero UUID; pass through the original pointer sonilstaysnil. - Ensures OLAP DAG creation receives a proper
NULLparent external ID instead of00000000-0000-0000-0000-000000000000.
juliusgeo
approved these changes
Apr 14, 2026
wsehl
pushed a commit
to wsehl/hatchet
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small fix for empty uuids, just need to pass the pointer
Type of change