Ignore invalid step IDs when inserting or replaying tasks#3735
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a nil-pointer panic in task creation/replay flows by skipping tasks whose StepId no longer exists (e.g., step deleted) before building per-step configuration-dependent fields.
Changes:
- Filter out
CreateTaskOptswith missingStepIdbefore callinginsertTasks. - Filter out
ReplayTaskOptswith missingStepIdbefore proceeding with replay logic (and log a warning when skipped).
Comments suppressed due to low confidence (1)
pkg/repository/task.go:2395
- The error wrap message here says "failed to get step expressions" but the call is to
getConcurrencyExpressions. This makes debugging misleading; update the message to reference concurrency expressions (and keep wording consistent withinsertTasks).
concurrencyStrats, err := r.getConcurrencyExpressions(ctx, tx, tenantId, stepIdsToConfig)
if err != nil {
return nil, fmt.Errorf("failed to get step expressions: %w", err)
}
grutt
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a nil pointer panic when a batch of tasks includes an invalid step ID.
Type of change