Assure msc device block size is not zero#1113
Merged
Merged
Conversation
hathach
approved these changes
Sep 30, 2021
Owner
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
Thank you very much for the PR. I take a look back at the MSC BOT specs, the case where total bytes < block num is actually counted as
- READ10: case 7 Hi < Di host read less than device want to send or
- WRITE10 (we need this check for write as well): case 13 Ho < Do, host send less than device would like to receive
In both cases, the specs say we must response with phase error. Therefore, I made a bit of changes and push the update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case total_bytes divided by block_count evaluates to zero a division by zero may happen in proc_read10_cmd leading to a crash.