Skip to content

Fix GUID of video compression formats#1143

Merged
hathach merged 1 commit into
hathach:masterfrom
kkitayam:fix_video_format_guid
Oct 14, 2021
Merged

Fix GUID of video compression formats#1143
hathach merged 1 commit into
hathach:masterfrom
kkitayam:fix_video_format_guid

Conversation

@kkitayam
Copy link
Copy Markdown
Collaborator

Describe the PR
GUID for uncompressed formats were wrong.

Additional context
The bug is mentioned by #1142 (comment)

@hathach
Copy link
Copy Markdown
Owner

hathach commented Oct 14, 2021

sorry, ci failed due to me messing up one of the tool for analyze the linker map. will fix it asap

Copy link
Copy Markdown
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested, linux does not complain about the format anymore. Thank you for the PR. Still haven't tried to find an app to test with, will do later on.

[149825.252622] usb 3-3: Product: TinyUSB Device
[149825.252623] usb 3-3: Manufacturer: TinyUSB
[149825.252624] usb 3-3: SerialNumber: 123456
[149825.260633] uvcvideo: Found UVC 1.50 device TinyUSB Device (cafe:4020)
[149825.260637] uvcvideo: No valid video chain found.

@hathach hathach merged commit 4d0cf61 into hathach:master Oct 14, 2021
@kkitayam kkitayam deleted the fix_video_format_guid branch October 15, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants