dwc2/host: HFIR: Fix timing off-by-one#3074
Merged
Merged
Conversation
Collaborator
|
Thank you ! Hum that's interesting, on databook 4.20a the |
HiFiPhile
approved these changes
Apr 11, 2025
Contributor
Author
|
Huh! I don't have access to their databook(s), unfortunately. So I just copied the mentioned versions from the mailing list thread! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
HFIR register for SOF timing was programmed with an off-by-one value (it needs a -1 applied).
This probably comes from a historical error in the Synopsys databook. They corrected it in version 3.30a, according to this comment on a mailinglist: https://lists.infradead.org/pipermail/linux-rpi-kernel/2016-February/003290.html
Also, the official Linux kernel dwc2 driver (maintained by Synopsys) contains the values with
-1offset, as can be seen in thedwc2_calc_frame_interval()function here:https://github.com/torvalds/linux/blob/900241a5cc15e6e0709a012051cc72d224cd6a6e/drivers/usb/dwc2/hcd.c#L326
@HiFiPhile @roma-jam