HWFIFO access-mode refactor and stride-aware FIFO fixes across FSDEV/RUSB2/MUSB #3441
+1,271
−1,347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
changed the title
hathach
force-pushed
the
fifo-access-mode
branch
from
7d8bd83 to
d61ed92
Compare
… duplicated packet write/read for fsdev
hathach
force-pushed
the
fifo-access-mode
branch
from
d7f3c3b to
9b5c776
Compare
hathach
force-pushed
the
fifo-access-mode
branch
from
b6a747e to
1112473
Compare
hathach
force-pushed
the
fifo-access-mode
branch
from
58be629 to
daf81b4
Compare
Size Difference ReportBecause TinyUSB code size varies by port and configuration, the metrics below represent the averaged totals across all example builds. Note: If there is no change, only one value is shown. Changes >1% in size
Changes <1% in size
No changes
|
hathach
force-pushed
the
fifo-access-mode
branch
from
daf81b4 to
0b638c5
Compare
hathach
force-pushed
the
fifo-access-mode
branch
from
9c59260 to
bd86717
Compare
rusb use custom write enable all hil test for ra4m1
hathach
force-pushed
the
fifo-access-mode
branch
from
bd86717 to
e158a3d
Compare
…eset delay for stable speed detection
hathach
force-pushed
the
fifo-access-mode
branch
from
6694bbd to
a9479f5
Compare
hathach
force-pushed
the
fifo-access-mode
branch
from
3c71b7d to
20d009d
Compare
hathach
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the HWFIFO access layer across multiple USB controllers (FSDEV, RUSB2, MUSB, DWC2) by removing the item_size concept from tu_fifo and moving to raw byte storage. The key changes include:
- Replaced fixed-address FIFO access enum with stride-aware access mode supporting configurable data and address strides
- Updated HWFIFO API with new tu_hwfifo_access_t structure and dedicated helper functions
- Removed FSDEV PMA packet helpers in favor of shared HWFIFO path
- Refactored RUSB2 and MUSB to use shared HWFIFO read/write functions
- Updated OSAL backends to track item_size separately from FIFO
- Added ENUM_RESET_ROOT_POST_DELAY_MS for stable speed detection in host stack
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit-test/test/test_fifo.c | Removed test_item_size test, updated TU_FIFO_INIT calls, added 16-bit stride tests |
| test/unit-test/project.yml | Updated test defines for new HWFIFO configuration |
| test/unit-test/CMakeLists.txt | Removed CFG_TUSB_FIFO_ACCESS_FIXED_ADDR_RW32 define |
| test/hil/tinyusb.json | Enabled RA4M1 device tests (removed skip list) |
| src/tusb_option.h | Added stride configuration for DWC2, FSDEV, MUSB, RUSB2 |
| src/tusb.c | Updated tu_fifo_config call to remove item_size parameter |
| src/portable/synopsys/dwc2/*.c | Replaced dfifo_read/write_packet with tu_hwfifo_read/write |
| src/portable/st/stm32_fsdev/*.c | Replaced fsdev packet memory functions with tu_hwfifo API |
| src/portable/st/stm32_fsdev/*.h | Removed FSDEV_PMA_SIZE macros, reorganized MCU definitions |
| src/portable/renesas/rusb2/*.c | Refactored to use shared HWFIFO, added custom write support |
| src/portable/mentor/musb/dcd_musb.c | Replaced pipe_read/write_packet with tu_hwfifo functions |
| src/osal/osal_pico.h, osal_none.h | Added item_size tracking for queues, updated to use tu_fifo_read/write_n |
| src/host/usbh.c | Added post-reset delay for root port enumeration |
| src/common/tusb_fifo.h | Removed item_size from tu_fifo_t, added tu_hwfifo_access_t |
| src/common/tusb_fifo.c | Refactored stride-aware read/write, removed item_size logic |
| src/common/tusb_mcu.h | Moved FSDEV_PMA_SIZE definitions to mcu.h |
| src/class/audio/audio_device.c | Updated tu_fifo_config calls |
| README.rst | Updated table descriptions for USB RAM terminology |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20d009daa1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple data stride widths (16/32) are supported.
tu_hwfifo_read_to_fifo.