Fix DFU descriptor version from 1.0.1 to 1.1.0#3480
Merged
Conversation
Co-authored-by: hathach <249515+hathach@users.noreply.github.com>
Co-authored-by: hathach <249515+hathach@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix DFU runtime descriptor version to 1.1
Fix DFU descriptor version from 1.0.1 to 1.1.0
Feb 3, 2026
Co-authored-by: hathach <249515+hathach@users.noreply.github.com>
Contributor
Author
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
TinyUSB Average Code Size Metrics
Input files
|
hathach
reviewed
Feb 3, 2026
Owner
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
@copilot fix zephyr build failed https://github.com/hathach/tinyusb/actions/runs/21622974282/job/62316454733?pr=3480
Co-authored-by: hathach <249515+hathach@users.noreply.github.com>
Contributor
Author
Fixed. The Zephyr build was failing because newer Zephyr versions require the full board qualifier format. Updated from |
Copilot
AI
changed the title
Fix DFU descriptor version from 1.0.1 to 1.1.0
Fix DFU descriptor version from 1.0.1 to 1.1.0 and Zephyr build
Feb 3, 2026
Collaborator
|
@hathach Zephyr build alias is bugged: |
Owner
ah thank, ok. Then we just make changes to usbd.h only, we can have the build failed for this PR. |
Owner
|
@copilot revert the zerphyr fix, since it is not our bug. |
Co-authored-by: hathach <249515+hathach@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Fix DFU descriptor version from 1.0.1 to 1.1.0 and Zephyr build
Fix DFU descriptor version from 1.0.1 to 1.1.0
Feb 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the DFU functional descriptor version from 0x0101 (1.0.1) to 0x0110 (1.1.0) to accurately reflect that TinyUSB implements DFU 1.1 features. The USB BCD format (0xJJMN for version JJ.M.N) requires version 1.1.0 to be represented as 0x0110, not 0x0101.
Changes:
- Updated DFU runtime descriptor version from 0x0101 to 0x0110
- Updated DFU mode descriptor version from 0x0101 to 0x0110
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
DFU functional descriptors were advertising version 0x0101 (1.0.1) despite TinyUSB implementing DFU 1.1 features. Per USB BCD format (0xJJMN for version JJ.M.N), version 1.1.0 is 0x0110.
Changed in
src/device/usbd.h:Both
TUD_DFU_RT_DESCRIPTOR(line 822) andTUD_DFU_DESCRIPTOR(line 836) updated.Additional context
Reference: DFU 1.1 specification §4.1.3 and USB 2.0 specification §9.6.1
Note: Zephyr build failures are due to an upstream Zephyr bug (zephyrproject-rtos/zephyr#103302) and are not addressed in this PR.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.