Fix membrowse job to run on all pushes for commit chain tracking

[Copilot]

The membrowse job was being skipped on doc-only pushes because its cmake dependency was gated on code_changed. This broke MemBrowse commit chain tracking.

Changes:

• Added always() && !cancelled() condition to run membrowse even when cmake is skipped
• Added explicit event checks: always run on push/release/workflow_dispatch, only run on PR if code changed
• Added check-paths to needs array to access code_changed output
• Pass actual code_changed value instead of hardcoded true

membrowse:
  needs: [check-paths, cmake]
  if: |
    always() && !cancelled() && (
      github.event_name == 'push' ||
      github.event_name == 'release' ||
      github.event_name == 'workflow_dispatch' ||
      (github.event_name == 'pull_request' && needs.check-paths.outputs.code_changed == 'true')
    )
  uses: ./.github/workflows/membrowse-report.yml
  with:
    code_changed: ${{ needs.check-paths.outputs.code_changed == 'true' || github.event_name == 'release' || github.event_name == 'workflow_dispatch' }}

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[hathach]

@membrowse does it look better ?

[michael-membrowse]

@membrowse does it look better ?

Yes, it should work

[hathach]

@membrowse does it look better ?

Yes, it should work

perfect, thank you

[Copilot]

Pull request overview

Adjusts the Build workflow so the membrowse reporting job runs on all pushes (including doc-only pushes) to preserve MemBrowse commit-chain tracking, while keeping PR behavior gated by actual code changes.

Changes:

• Make membrowse resilient to skipped upstream jobs by using always() && !cancelled() and adding check-paths to needs.
• Add event-based gating: always run on push/release/workflow_dispatch, run on pull_request only when code_changed == 'true'.
• Pass a computed code_changed value to the reusable membrowse-report.yml workflow instead of hardcoding true.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Using always() at the job level means membrowse will also run when cmake fails, not just when it’s skipped. In that case membrowse-report.yml will likely fall back to the identical: true path (no ELF), which can misrepresent a real code change/build failure as a doc-only/identical report. Consider additionally gating on needs.cmake.result != 'failure' (or needs.cmake.result == 'success' || needs.cmake.result == 'skipped') while keeping always() so it still runs when cmake is skipped.

[Copilot]

code_changed is defined as “Whether code paths changed (true) or doc-only (false)” in membrowse-report.yml, but here it’s forced to true for release/workflow_dispatch regardless of what check-paths computed. This can cause the reusable workflow to attempt artifact download/restore steps even when set-matrix/cmake were skipped (no artifacts), and it blurs the meaning of the input. Consider passing the actual needs.check-paths.outputs.code_changed == 'true' value and, if you need different behavior for release/manual runs, introduce a separate explicit input/flag for that behavior.

Suggested change

	code_changed: ${{ needs.check-paths.outputs.code_changed == 'true' || github.event_name == 'release' || github.event_name == 'workflow_dispatch' }}
	code_changed: ${{ needs.check-paths.outputs.code_changed == 'true' }}