device/msc: limit EP OUT stall check to STATUS_SENT transition#3493
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up to #3471 to avoid asserting when re-arming the MSC command stage while the Bulk OUT endpoint is halted, by limiting the stall check to the MSC_STAGE_STATUS_SENT -> MSC_STAGE_CMD transition.
Changes:
- Revert the “skip CBW queueing when EP OUT is stalled” logic from
prepare_cbw(). - In
mscd_xfer_cb()(after CSW IN completes), only queue the next CBW if EP OUT is not stalled; otherwise just transition toMSC_STAGE_CMDand wait for host ClearFeature(HALT).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TinyUSB Average Code Size Metrics
Input files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3471.
This keeps
prepare_cbw()behavior unchanged (set CMD + queue CBW) and only defers queueing inMSC_STAGE_STATUS_SENTwhen EP OUT is stalled.Changes:
prepare_cbw()MSC_STAGE_STATUS_SENT, if EP OUT is stalled: setstage = MSC_STAGE_CMDwithout queuing transferprepare_cbw()as beforeRationale:
prepare_cbw()call sites (open/reset-recovery) should keep original semantics