Skip to content

Remove 0xEE index string if statement & change TU_ASSERT to TU_VERIFY#466

Merged
hathach merged 1 commit into
hathach:masterfrom
chang196700:feature/string_desc_msos
Jul 21, 2020
Merged

Remove 0xEE index string if statement & change TU_ASSERT to TU_VERIFY#466
hathach merged 1 commit into
hathach:masterfrom
chang196700:feature/string_desc_msos

Conversation

@chang196700
Copy link
Copy Markdown
Contributor

@chang196700 chang196700 commented Jul 19, 2020

Describe the PR
close #459

Signed-off-by: Chang Feng <chang_196700@hotmail.com>
Copy link
Copy Markdown
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, now I need to spam all the examples tud_descriptor_string_cb() with the quote :D. Note this MS OS Descriptor is v1 and applied only to win7 and prio. Win8 and win10 use BOS to retrieve MS OS v2

// The 0xEE index string is a Microsoft OS Descriptors.	
// https://docs.microsoft.com/en-us/windows-hardware/drivers/usbcon/microsoft-defined-usb-descriptors

@hathach hathach merged commit be744e1 into hathach:master Jul 21, 2020
@hathach hathach mentioned this pull request Jul 21, 2020
@chang196700 chang196700 deleted the feature/string_desc_msos branch July 23, 2020 06:41
7FM pushed a commit to 7FM/tinyusb that referenced this pull request Aug 23, 2025
also add static check for USB DPRAM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why return false directly without leaving a callback to decide the result?

2 participants