Make the disk disappear on Windows after it was ejected#551
Merged
Conversation
Make the disk disappear on Windows after it was ejected. The device need to be re-inserted or reseted to re-appear again. This doesn't affect Linux where the device can be mounted and unmounted repeatedly. Closes hathach#549
hathach
reviewed
Nov 6, 2020
Owner
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
look good but I think the comment has a typo
| (void) lun; | ||
|
|
||
| return true; // RAM disk is always ready | ||
| // RAM disk is ready until is not ejected |
Owner
There was a problem hiding this comment.
hmm the comment should be until ejected without NOT.
hathach
approved these changes
Nov 8, 2020
Owner
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
thank for the PR, will merge and correct the comment as follow up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the disk disappear on Windows after it was ejected. The device needs to be re-inserted or reseted to re-appear again.
This doesn't affect Linux where the device can be mounted and unmounted repeatedly.
Note that this should be applied to three more examples.
Closes #549