Skip to content

Dcd synopsis mem allocation#581

Merged
hathach merged 5 commits into
masterfrom
dcd_synopsis_mem_allocation
Jan 8, 2021
Merged

Dcd synopsis mem allocation#581
hathach merged 5 commits into
masterfrom
dcd_synopsis_mem_allocation

Conversation

@PanRe
Copy link
Copy Markdown
Collaborator

@PanRe PanRe commented Jan 3, 2021

Describe the PR
Implementation of #540.
TX FIFOs are now starting to allocate from the top, RX FIFO at the bottom of the available space (like heap and stack). As such, free space is between TX and RX allocations allowing the RX FIFO to grow in size dynamically which is needed in case an ISO OUT EP is opened which is greater than the standard RX FIFO size. Also, once such an OUT EP is closed, the RX FIFO size will be reduced once the RX FIFO is empty.

Comment thread src/portable/st/synopsys/dcd_synopsys.c Outdated
Copy link
Copy Markdown
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb !!! Thank you very much for the PR, it looks great. I haven't tested it on hardware (will do later on), I only have a couples of feedback per review. Let's me know if you think otherwise.

Comment thread src/portable/st/synopsys/dcd_synopsys.c Outdated
Comment thread src/portable/st/synopsys/dcd_synopsys.c Outdated
Comment thread src/portable/st/synopsys/dcd_synopsys.c Outdated
Comment thread src/portable/st/synopsys/dcd_synopsys.c Outdated
Reinhard Panhuber added 2 commits January 4, 2021 17:00
- externerlize code into functions
- correct comments
Copy link
Copy Markdown
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR !!! Thank you very much for putting effort into this work.

Comment thread src/portable/st/synopsys/dcd_synopsys.c
@hathach hathach merged commit 1f00a18 into master Jan 8, 2021
@hathach hathach deleted the dcd_synopsis_mem_allocation branch January 8, 2021 05:45
@PanRe
Copy link
Copy Markdown
Collaborator Author

PanRe commented Jan 9, 2021

Thanks! I am glad you like my ideas :)

@hathach
Copy link
Copy Markdown
Owner

hathach commented Jan 11, 2021

Thanks! I am glad you like my ideas :)

it is a great idea, hopefully after a few round of enhancement like this pr, we could have a great FIFO allocation scheme.

7FM pushed a commit to 7FM/tinyusb that referenced this pull request Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants