add basic support for rt-thread#637
Conversation
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
PR lack define value for OPT_OS_RTTHREAD. Is it easy enough to add cdc_msc_rtthread example so that we could avoid building issue like this for future changes.
|
It is my mistake. I'm a student developer in university, and I am still studying embedded development. Maybe add In fact, the RT-Thread team already provides a USB Device stack in RT-Thread, but not in RT-Thread Nano (the RTOS kernel of RT-Thread). I hope to provide more options for Chinese developers. Thank you for your review. |
|
no problem at all if you think adding the example is not trivial, though have you been able to run rt-thread with tinyusb successfully on their studio IDE ? |
|
Yes. I have tested it in RT-Thread Studio, I've also tested it in my own CMake project with RT-Thread Nano. They all work fine. |
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
Thanks for the PR, It looks good. There is only a request to suppress unused warning and a bit of code style. Afterwards this should be good for the merge
| osal_queue_def_t _name = { \ | ||
| .depth = _depth, .item_sz = sizeof(_type), .buf = _name##_##buf}; |
There was a problem hiding this comment.
please merge this 2 line together, also needs a space between ##buf and closing }
That is good enough for this PR |
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
look good, thanks for the PR. Will merge when ci complete
2 participants
Describe the PR
Add a basic support for RT-Thread RTOS. More about the RT-Thread.
Additional context
None.