Skip to content

[msp430]: a way skip nanolib for MSP430#685

Closed
Pillar1989 wants to merge 1 commit into
hathach:masterfrom
Pillar1989:master
Closed

[msp430]: a way skip nanolib for MSP430#685
Pillar1989 wants to merge 1 commit into
hathach:masterfrom
Pillar1989:master

Conversation

@Pillar1989
Copy link
Copy Markdown

I think that's a way to remove one to-do item in your code.

@cr1901
Copy link
Copy Markdown
Collaborator

cr1901 commented Feb 26, 2021

Well, that indeed works for boards from TI, but I wanted something specific to "projects using msp430 the arch", regardless of which board you're using.

And I forgot at this point why this was a "TODO" (maybe there's no easy way to extract arch using rules.mk?). Your patch is fine for now tho.

@hathach
Copy link
Copy Markdown
Owner

hathach commented Feb 26, 2021

not all board will have an msp_exp430 in their name. Marketing people will prefer to have AI, Super, in the product name 😄 . @cr1901 we can do it simply by moving msp430 into its own family with shared `family.mk' e.g stm32f4 https://github.com/hathach/tinyusb/tree/master/hw/bsp/stm32f4 . Though I am too lazy to do that with a family with only 1 board 😄 . will wait until some people make PR for another msp430 .

PS: it is in the common rules.mk, moving to family with skip nanolib flags maybe better. But I think using the CROSS_COMPILE test with msp430-elf- would be great for now.

Copy link
Copy Markdown
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use CROSS_COMPILE which is more accurate in this case.

Comment thread examples/rules.mk

# TODO Skip nanolib for MSP430
ifeq ($(BOARD), msp_exp430f5529lp)
ifeq ($(findstring msp_exp430,$(BOARD)), msp_exp430)
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use CROSS_COMPILE which is more accurate in this case.

ifeq ($(CROSS_COMPILE), msp430-elf-)

@Pillar1989
Copy link
Copy Markdown
Author

It looks like you can easily modify it just a bit.

@Pillar1989 Pillar1989 closed this Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants