SAM 54 Xplained Pro: fix inverted logic for board led#687
Merged
hathach merged 2 commits intoFeb 28, 2021
Conversation
hathach
requested changes
Feb 28, 2021
Owner
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
There is led pin typo in function off
| gpio_set_pin_function(BUTTON_PIN, GPIO_PIN_FUNCTION_OFF); | ||
| gpio_set_pin_direction(LED_PIN, GPIO_DIRECTION_OUT); | ||
| gpio_set_pin_level(LED_PIN, 0); | ||
| gpio_set_pin_level(LED_PIN, 1); |
Owner
There was a problem hiding this comment.
How about board_led_write(0) to set led to off
hathach
approved these changes
Feb 28, 2021
Owner
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
Look great, thank you for the pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the inverted board led logic. the LED was on by default, board_led_write(1) would turn it off.