Improve rp2040#692
Merged
Merged
Conversation
- move target_link_libraries() to family.cmake - enable pico_bootsel_via_double_reset
add note for segger rtt block search range
- also use dcd_event_bus_reset() - Add TODO for suspend, resume later on (need to test with/without vbus detection).
hathach
commented
Mar 3, 2021
Owner
Author
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
Merged now, will do a bit more in-depth testing between bus reset and disconnection later on. More detail adafruit/circuitpython#4066 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
pico_bootsel_via_double_resetfor all examplesAll CMakelists.txt are updated, just ignore it, the interested modification is in
dcd_rp2040.c