Add back cmsis5 as submodule#708
Merged
Merged
Conversation
Contributor
|
Does this mean that we now need to update submodules recursively in order to get TinyUSB to compile? In CircuitPython we have been disrecommending |
Owner
Author
|
@dhalbert circuitpython or any super project only need to check out tinyusb and shouldn’t check out any submodules of tinyusb to compile. Super project should only use src folder of tinyusb, any other submodules/folder are subject to change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Add back lib/CMSIS_5 as submodules #705 . Also slightly optimize ci submodules checkout