When used with FreeRTOS, lower the interrupt priority for OTG_FS_IRQn#789
Merged
Conversation
hathach
approved these changes
Apr 18, 2021
Owner
hathach
left a comment
There was a problem hiding this comment.
Thank for the fix, yeah, this is very common issue when using cortex m with freertos. I have this nvic setprio for most of family, but apparently not all of them. This is downside of having too many boards/ports, that sometime I couldn't do all the hand-on testing on actual hardware
Note: The issue is only occurred if default priority (on reset) of USB is too high, somehow my stmf411disco board work just fine without this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of the FreeRTOS examples currently work with STM32F4, they all trigger this assert in
lib/FreeRTOS-Kernel/portable/GCC/ARM_CM4F/port.c:764 configASSERT( ucCurrentPriority >= ucMaxSysCallPriority );because the interrupt priority for OTG_FS is too high (that is, the value of
ucCurrentPriorityis too low).The (almost) correct call to
NVIC_SetPrioritywas commented out inhw/bsp/stm32f4/family.c.I have a suspicion that other Cortex-M chips might be affected too, but I can only test Seeeduino Xiao and STM32F4 blackpill.