Skip to content

Uac2 fix cs as int alt set 0#798

Merged
hathach merged 5 commits into
masterfrom
uac2_fix_cs_as_int_alt_set_0
Apr 22, 2021
Merged

Uac2 fix cs as int alt set 0#798
hathach merged 5 commits into
masterfrom
uac2_fix_cs_as_int_alt_set_0

Conversation

@PanRe
Copy link
Copy Markdown
Collaborator

@PanRe PanRe commented Apr 20, 2021

Describe the PR
Fix bug where the pointer uint8_t * alt_setting was reset to zero when the audio interface was opened by host. Refactor some static functions for faster checks and renamed old depracted and misleading variable names.

Copy link
Copy Markdown
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, the review is nothing big, just a minor comment on variable naming and a redundant volatile.

Comment thread src/class/audio/audio_device.c Outdated
Comment thread src/class/audio/audio_device.c Outdated
Copy link
Copy Markdown
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks perfect now.

@hathach hathach merged commit d8fd435 into master Apr 22, 2021
@hathach hathach deleted the uac2_fix_cs_as_int_alt_set_0 branch April 22, 2021 03:56
7FM pushed a commit to 7FM/tinyusb that referenced this pull request Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants