Fix fifo overflow correction.

[HiFiPhile]

Describe the PR
Fix fifo overflow correction.

Additional context
If applicable, add any other context about the PR and/or screenshots here.

[HiFiPhile]

For advance_pointer

  if ((p > p + offset) || (p + offset > f->max_pointer_idx))
  {
    p = (p + offset) + f->non_used_index_space;
  }
  else
  {
    p += offset;
  }

I feel like the check can be simplified into if (p + offset > f->max_pointer_idx)), have I missed something ?

[PanRe]

For advance_pointer

  if ((p > p + offset) || (p + offset > f->max_pointer_idx))
  {
    p = (p + offset) + f->non_used_index_space;
  }
  else
  {
    p += offset;
  }

I feel like the check can be simplified into if (p + offset > f->max_pointer_idx)), have I missed something ?

The first condition covers the case when p overflows solely by offset. It is possible that the second condition never hits i.e. if offset is big enough to "jump over" the non-used index space.

[hathach]

The GCC seem to be right about this. I got the warning when compiling with gnu++17, haven't got time to trace it down. So I put the warning comment here. Thanks for the PR.

[hathach]

Superb! Thank you @HiFiPhile for fixing the issue and @PanRe for reviewing it. I will try to recompile with gcc++17 later on, and remove warning comment if it is indeed the case.