Merged
Conversation
grk_compress expected -S and -E instead of -SOP and -EPH see hathitrust/feed@c4099fe
Member
Author
|
FYI @carylwyatt if you want to try this branch in dev to see if it fixes the issues you were running into. You may need to clear out |
Member
|
@aelkiss I tested this branch on dev-3 and PDFs that previously failed are now downloading without issue. Hooray! |
moseshll
approved these changes
Apr 17, 2026
Contributor
moseshll
left a comment
moseshll
left a comment
There was a problem hiding this comment.
I'm also perplexed as to why all jp2s don't fail miserably, but that's for another day. Checks out on dev-2. APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grk_compress expected -S and -E instead of -SOP and -EPH
see hathitrust/feed@c4099fe
I'm not sure how or why the export format gets set to
image/jp2when generating PDFs (or rather how to replicate it in a test) and why it only happens for certain source images (it doesn't seem to be all JPEG2000 images, or presumably we'd hear about download being completely broken), but this seems to be the cause of the problem we're having with certain downloads.