Skip to content

ETT-477 under_server fix#206

Merged
moseshll merged 2 commits into
mainfrom
ETT-477_under_server_fixup
May 13, 2026
Merged

ETT-477 under_server fix#206
moseshll merged 2 commits into
mainfrom
ETT-477_under_server_fixup

Conversation

@moseshll
Copy link
Copy Markdown
Contributor

  • Restore use Debug::DUtils; incorrectly removed from ETT-477 branch
  • Decided to avoid getting bogged down in test config since adding a simple test aith q1 param to plack.t does not expose a failure (although it complains about things like PTSEARCH_SOLR).

 - Restore `use Debug::DUtils;` incorrectly removed from ETT-477 branch
 - Decided to avoid getting bogged down in test config since adding a simple test aith `q1` param
   to plack.t does not expose a failure (although it complains about things like `PTSEARCH_SOLR`).
@moseshll moseshll requested a review from aelkiss May 11, 2026 14:40
@aelkiss
Copy link
Copy Markdown
Member

aelkiss commented May 12, 2026

Yeah I think this is fine. We could consider adding a playwright test that exercises this feature at some point but I don't think now needs to be the time. I'm a little surprised the validate_app checks (called by stage_app) didn't catch it when you put it on test.babel though.

@aelkiss
Copy link
Copy Markdown
Member

aelkiss commented May 12, 2026

OK so it looks like validate-config.yaml doesn't have any check for the html or text endpoints. I think it would be worth adding something there that could have caught this issue.

@moseshll
Copy link
Copy Markdown
Contributor Author

Looks like ocr is a synonym for html and I didn't see a text endpoint -- hard for me to keep track of what is a synonym for what sometimes. Anyway, here's to an additional layer of protection.

@moseshll moseshll merged commit a47fc4b into main May 13, 2026
2 checks passed
@moseshll moseshll deleted the ETT-477_under_server_fixup branch May 13, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants