-
Notifications
You must be signed in to change notification settings - Fork 0
Ett 1155 clean up #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ett 1155 clean up #101
Conversation
aee13b3 to
a0d9230
Compare
|
The result cookie & the ezproxy thing was handled here: #103 It looks like now there are some conflicts with this branch, just let me know if you'd like me to try to address those. |
|
sys/VFUser.php can be removed too. We will have to remove the dependency from require_once 'sys/VFUser.php'; |
|
This is on dev-2 |
moseshll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good place to leave things.
760058b to
82c407f
Compare
e46f3d1 to
08e074c
Compare
…g legacy authentication
- These can be used in production and although it shouldn't be a security issue it feels gross - The HTStatus `fakefill` utilities are unneeded with this removal
Using isCached instead of is_cached seems to be the only required change.
08e074c to
3696e98
Compare
This PR consists of several features that have been removed from the Catalog. After removing the features, I updated the Smarty template to ensure variables are not empty.
I have commented out all the logic related to the
$uservariable. Although we know the $user is always Null in Holdings.php, aglobal $useris defined. I want to confirm this part with @moseshll to ensure it is safe to remove.If
$recordcountis not defined, I have set it to 0 by default in the template. However, this variable is initialized in services/Search/Home.php and in services/Record/Record.phpI would like to check if we should set up a default value on the PHP side
Additional things we should check: