Skip to content

Conversation

@liseli
Copy link
Contributor

@liseli liseli commented Dec 10, 2025

This PR consists of several features that have been removed from the Catalog. After removing the features, I updated the Smarty template to ensure variables are not empty.

I have commented out all the logic related to the $user variable. Although we know the $user is always Null in Holdings.php, a global $user is defined. I want to confirm this part with @moseshll to ensure it is safe to remove.

If $recordcount is not defined, I have set it to 0 by default in the template. However, this variable is initialized in services/Search/Home.php and in services/Record/Record.php

$recordCount =  $result['RecordCount'];

I would like to check if we should set up a default value on the PHP side

Additional things we should check:

  • How to remove this error "NOTICE: PHP message: can't write resultIDs cookie, length is 14200"? --> Check the comments here
  • The RecordUtils.php EZproxy logic that depends on $inst will never select the Flint proxy because inst is never set.

@liseli liseli force-pushed the ETT-1155_cleanUp branch 2 times, most recently from aee13b3 to a0d9230 Compare December 10, 2025 18:42
@liseli liseli requested a review from moseshll December 10, 2025 20:41
@aelkiss
Copy link
Member

aelkiss commented Dec 12, 2025

The result cookie & the ezproxy thing was handled here: #103

It looks like now there are some conflicts with this branch, just let me know if you'd like me to try to address those.

@liseli
Copy link
Contributor Author

liseli commented Dec 12, 2025

sys/VFUser.php can be removed too. We will have to remove the dependency from require_once 'sys/VFUser.php'; Search/Home.php, SearchExport.php and SearchExtructure.php

@moseshll
Copy link
Contributor

This is on dev-2

Copy link
Contributor

@moseshll moseshll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good place to leave things.

@aelkiss aelkiss force-pushed the ETT-1155_cleanUp branch 3 times, most recently from e46f3d1 to 08e074c Compare December 15, 2025 19:39
@aelkiss aelkiss merged commit ed38641 into main Jan 12, 2026
2 checks passed
@aelkiss aelkiss deleted the ETT-1155_cleanUp branch January 12, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants