ETT-1245 record error page has undefined recordCount #119
Conversation
- The various `interface/` templates that refer to this variable treat it inconsistently. - Giving `recordCount` a `|default:0` silences the error - Some templates gave it a `|default:"0"` which is confusing and unnecessary since it's for an HTML attribute - changed to just `0` - `recordCount` appears not be used anywhere in the `Record` hierarchy of templates/PHP code, do we even need `data-record-count` in the Record error template?
aelkiss
left a comment
aelkiss
left a comment
There was a problem hiding this comment.
Looks good to me. I think the question of whether we could omit data-record-count entirely is for @carylwyatt.
carylwyatt
left a comment
carylwyatt
left a comment
There was a problem hiding this comment.
There's nothing in firebird that references data-record-count or handles a custom data attribute via the document.body.dataset property (searched for dataset.recordCount). I double-checked the catalog for that type of handling and couldn't find anything here, either. Nothing in babel uses data-record-count either. Custom data attributes like that are usually there to be manipulated by javascript for some purpose, and I thought perhaps it was a clicklogger thing, but I can't find any reference to it outside of catalog. Very weird!
Feel free to delete it, I highly doubt it's doing anything.
…n `interface/themes/firebird/Record` - Leaving it alone in `interface/themes/firebird/Search` -- it may not be used there either but seems more relevant
data-record-countattribute.interface/templates that refer to this variable treat it inconsistently.recordCounta|default:0silences the error|default:"0": confusing and unnecessary since it's for an HTML attribute - changed to just0recordCountappears not be used anywhere in theRecordhierarchy of templates/PHP code, do we even needdata-record-countin the Record error template? If not then the best approach is probably to remove it. It may be copy-pasta from theSearchside.