ETT-1253 Removing advanced search filter should remove adv=1 #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When you do an advanced catalog search and then remove the filter that correspondings to the advanced search terms, currently the adv=1 flag is still present in the URL. - This changes `SearchStructure->asWildcardURL(...)` -- which is only used for filter removal URLs -- not to include `adv`.
carylwyatt
approved these changes
Jan 16, 2026
Member
carylwyatt
left a comment
carylwyatt
left a comment
There was a problem hiding this comment.
Yep, works as expected! Approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchStructure->asWildcardURL(...)-- which is only used for filter removal URLs -- not to includeadv.To test:
https://catalog.hathitrust.org/Search/Home?type%5B%5D=author&lookfor%5B%5D=jones&bool%5B%5D=AND&type%5B%5D=title&lookfor%5B%5D=sanskrit&filter%5B%5D=language%3AEnglish&pagesize=100&ft=ft&adv=1
If you inspect the "remove filter" X button for the "Author: jones AND Title: sanskrit" facet in production,
adv=1is present, and if you click it then the advanced search terms are gone but the "Revise this advanced search" button is still there.Contrast with:
https://dev-2.catalog.hathitrust.org/Search/Home?type%5B%5D=author&lookfor%5B%5D=jones&bool%5B%5D=AND&type%5B%5D=title&lookfor%5B%5D=sanskrit&filter%5B%5D=language%3AEnglish&pagesize=100&ft=ft&adv=1