Add option for checking out submodules when building#6
Merged
Conversation
aelkiss
added a commit
to hathitrust/hathifiles
that referenced
this pull request
Nov 11, 2022
Requires hathitrust/github_actions#6 to be merged & tagged as v3
aelkiss
force-pushed
the
build-submodules
branch
from
94b1d5c to
ff11cfc
Compare
aelkiss
changed the title
moseshll
approved these changes
Nov 11, 2022
Contributor
moseshll
left a comment
moseshll
left a comment
There was a problem hiding this comment.
I can imagine arguments for & against having default: false given the "you probably want to set this" note. But we should probably be in the practice of explicitly setting these flags without relying on defaults, so no harm either way.
Member
Author
|
Right, I was waffling, but I ultimately decided that 1) since the default for the checkout action is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't love submodules, but if we're using them, we need to have the option to bake them into any resulting Docker image (see hathitrust/hathifiles#29)