Skip to content

Conversation

@moseshll
Copy link
Collaborator

@moseshll moseshll commented Jan 31, 2026

  • This adds the data-show-columns attribute to Approval Requests, Institutions, Registrations, and Users tables.
  • The ticket did not call for Institutions, however I folded it in for consistency.
  • Uses Table Cookie extension to persist hidden columns, and for good measure rows per page in the ht_downloads index page.
  • Some minor formatting cleanup.
  • No actual code changes, so no test changes.

Reviewer: this (minus the most recent commit [downloads rows-per-page cookification]) can be tested directly at https://preview.babel.hathitrust.org/otis (VPN required). The column show/hide doodly-doo looks like this:
Screenshot 2026-02-06 at 4 48 46 PM
and you should be able to accomplish column hidings that persist across reloads and navigation.

- This adds the `data-show-columns` attribute to Approval Requests, Institutions, Registrations, and Users tables.
- The ticket did not call for Institutions, however I folded it in for consistency.
- Some minor formatting cleanup.
- No actual code changes, so no test changes.
@coveralls
Copy link

coveralls commented Jan 31, 2026

Coverage Status

coverage: 98.249% (+0.001%) from 98.248%
when pulling e864905 on ETT-1184_data-show-columns
into cf81157 on main.

@moseshll moseshll requested a review from carylwyatt February 6, 2026 21:51
Copy link
Member

@carylwyatt carylwyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview was giving me a 404 for whatever reason, but I pulled this down locally and it looks good! I like the addition of the cookie to remember the user preference on the table columns. Do you think 7 days is long enough? If this is something Melissa is using this frequently, I might go 90-180 days so it's not as annoying to reset. Just a thought.

@moseshll
Copy link
Collaborator Author

moseshll commented Feb 9, 2026

@carylwyatt you know, that is the right thing to do, seven days is silly -- I think I will choose 90 days, but I want to extract that setting out into the config somewhere instead of just repeating a new value everywhere.

Expose this value through `ApplicationPresenter` class method `data_cookie_expire`
@moseshll moseshll marked this pull request as ready for review February 9, 2026 19:57
@moseshll moseshll merged commit c2e4a21 into main Feb 9, 2026
1 check passed
@moseshll moseshll deleted the ETT-1184_data-show-columns branch February 9, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants