Skip to content

feat: migrate app styling to tailwind#11

Merged
nonnil merged 2 commits intotriagefrom
triage-tailwind-migration
May 10, 2026
Merged

feat: migrate app styling to tailwind#11
nonnil merged 2 commits intotriagefrom
triage-tailwind-migration

Conversation

@nonnil
Copy link
Copy Markdown
Member

@nonnil nonnil commented May 10, 2026

Summary

  • Add Tailwind CSS v4 through @tailwindcss/vite and replace the global app.css styling entry with src/styles/tailwind.css.
  • Move shell, browse, highlights, reader, and 404 styling into component-local Tailwind classes.
  • Add regression coverage that enforces the Tailwind integration and app.css removal.

Verification

  • mise exec -- bun run verify
  • mise exec -- bun run test:e2e
  • mise exec -- bun run dev:smoke
  • git diff --check
  • pre-push hook: typecheck, test, build

Visual smoke

  • /memories desktop: /private/tmp/trauma-tailwind-screens/memories-desktop.png
  • /memories mobile: /private/tmp/trauma-tailwind-screens/memories-mobile.png
  • /highlights desktop: /private/tmp/trauma-tailwind-screens/highlights-desktop.png
  • /memories/:id reader desktop: /private/tmp/trauma-tailwind-screens/reader-desktop.png

Notes

  • The existing .memory-grid class is retained only as an E2E hook; styling is Tailwind-based.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 10, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7d2243db-6876-43f7-a6bf-80f8a2bd4967

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch triage-tailwind-migration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cad33dc27b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/components/shell/AppShell.tsx Outdated
Comment thread src/styles/app.css
Copy link
Copy Markdown
Member Author

@nonnil nonnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nonnil
Copy link
Copy Markdown
Member Author

nonnil commented May 10, 2026

review @copilot @codex

Copy link
Copy Markdown
Contributor

Copilot AI commented May 10, 2026

review @copilot @codex

Reviewed. The migration looks clean:

  • src/styles/tailwind.css replaces app.css with a proper Tailwind v4 @import "tailwindcss" entry and @theme tokens for the design system colours.
  • app.config.ts registers the @tailwindcss/vite plugin correctly.
  • All five component files (AppShell, MemoryBrowse, MemoryReader, highlights, 404, and the memory reader route) have had their legacy semantic CSS class names replaced with Tailwind utility classes.
  • .memory-grid is retained only as an E2E selector hook, not for styling — that's the right call.
  • The contract test in tests/scripts/tailwind-migration.test.ts enforces both the structural requirements (plugin registered, app.css absent, tailwind.css imported) and the removal of the forbidden class names.
  • CI on the triage base branch is green.

No issues to flag.

@chatgpt-codex-connector
Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

Copilot finished work on behalf of nonnil May 10, 2026 05:17
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nonnil nonnil merged commit c42fd97 into triage May 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants