feat: implement task 18 memory actions by nonnil · Pull Request #21 · hauntedfail/Trauma

nonnil · 2026-05-15T19:49:52Z

Summary

Implements Task 18 memory actions across read status, delete, taxonomy, reader actions, settings auth state, explicit highlights, Flashbacks, and imported media policy.
Stabilizes integration/E2E coverage for native memory links, explicit highlight actions, reader highlight fixtures, phone tabs, and Solid hydration.
Keeps the branch scoped to Task 18 implementation and related verification fixes.

Verification

git diff --check
mise exec -- bun run test:e2e: 31 passed
mise exec -- bun run verify: typecheck, 69 Vitest files / 430 tests, production build passed

Notes

Existing unrelated untracked files were left untouched: TEMP_MAIN_CONTENT_EXTRACTION_VALIDATION_REPORT.md, app.config.timestamp_1778391094301.js, refined_sample/.

coderabbitai · 2026-05-15T19:49:58Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 392eab95-0b9a-485a-8339-f48e1271b78c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/task-18-memory-actions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cad69b1d10

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Trauma/src/components/reader/MemoryReader.tsx

Line 1005 in 8020e75

const failure = await readHighlightFailure(response);

Refresh highlight lists after successful toggles

When a reader creates or removes a highlight, this path only checks for a failure and never consumes the successful response or revalidates the highlight queries/reader state. In the side rail added by this change, the "This memory" and "All highlights" tabs are populated from the initial props/cached getHighlightBrowseRows, so a successful highlight toggle updates the article markup but leaves those lists stale until a reload or unrelated revalidation.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 427535690f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…t/task-18-memory-actions

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e66e649ac1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c860c72f8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

nonnil · 2026-05-17T20:40:51Z

review @copilot @codex

Copilot · 2026-05-17T20:41:45Z

review @copilot @codex

Reviewed on commit c53b1b1. I checked Actions on workflow18-read-status first, then feat/task-18-memory-actions; there are no completed failing runs requiring follow-up changes. No UI changes were made in this pass.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c53b1b16d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

nonnil · 2026-05-17T21:40:19Z

review @copilot @codex

Copilot · 2026-05-17T21:41:12Z

review @copilot @codex

Reviewed on commit d6c69ca. I checked Actions on workflow18-read-status first, then feat/task-18-memory-actions; there are no completed failing runs requiring follow-up changes. No UI changes were made in this pass.

chatgpt-codex-connector · 2026-05-17T21:41:18Z

To use Codex here, create a Codex account and connect to github.

chatgpt-codex-connector · 2026-05-17T21:47:02Z

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

nonnil · 2026-05-17T22:42:09Z

review @copilot @codex

Copilot · 2026-05-17T22:42:56Z

review @copilot @codex

Reviewed on commit 71ff5aa. I checked Actions on workflow18-read-status first, then feat/task-18-memory-actions; there are no completed failing runs requiring follow-up changes. No UI changes were made in this pass.

nonnil

👁️

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71ff5aa37c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

nonnil · 2026-05-17T23:08:10Z

review @copilot @codex

Copilot · 2026-05-17T23:09:04Z

review @copilot @codex

Reviewed on commit 28818b6. I checked Actions on workflow18-read-status first, then feat/task-18-memory-actions; there are no completed failing runs requiring follow-up changes. No UI changes were made in this pass.

chatgpt-codex-connector · 2026-05-17T23:16:52Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

nonnil added 11 commits May 16, 2026 00:39

feat: add memory metadata repository foundation

1d7284b

feat: expose memory metadata mutation APIs

dca9350

feat: add memory action UI primitives

f61ad7d

feat: wire browse memory actions

1a62698

feat: manage taxonomy from right rail

575cbf1

feat: wire reader memory actions

d7085b8

feat: add settings and OpenAI auth state

a677e05

feat: require explicit reader highlight actions

896a3e8

feat: add flashback section bookmarks

38ce920

feat: relax imported media display policy

b274545

test: stabilize task 18 integration flows

cad69b1

chatgpt-codex-connector Bot reviewed May 15, 2026

View reviewed changes

Comment thread src/server/highlights/toggle.ts Outdated

Comment thread src/server/memories/delete-memory.ts Outdated

Comment thread src/components/reader/MemoryReader.tsx

Comment thread src/components/flashback/FlashbackBrowse.tsx Outdated

fix: keep browse loader database open

8020e75

chatgpt-codex-connector Bot reviewed May 15, 2026

View reviewed changes

Comment thread src/components/memories/MemoryBrowse.tsx

Comment thread src/components/memories/MemoryBrowse.tsx

Comment thread src/server/reader/page-data.ts Outdated

Comment thread src/components/memories/MemoryReadStatusControl.tsx Outdated

Comment thread src/components/reader/MemoryReader.tsx

nonnil added 2 commits May 16, 2026 07:25

refactor: share segmented toggle button

4275356

refactor: unify right rail highlight lists

1e8247c

chatgpt-codex-connector Bot reviewed May 15, 2026

View reviewed changes

Comment thread src/components/reader/MemoryReader.tsx Outdated

Comment thread src/components/reader/MemoryReader.tsx

Comment thread src/components/reader/MemoryReader.tsx

nonnil added 5 commits May 16, 2026 07:47

fix: show check icon for read memories

8627b4f

fix: clarify memory action menu hover

0c9e3ab

Merge remote-tracking branch 'origin/workflow18-read-status' into fea…

f1ffbd5

…t/task-18-memory-actions

fix: shorten highlight tab label

2b15ed7

fix: align task 18 review followups

e66e649

chatgpt-codex-connector Bot reviewed May 16, 2026

View reviewed changes

Comment thread src/server/highlights/toggle.ts Outdated

Comment thread src/server/highlights/toggle.ts Outdated

Comment thread src/server/memories/delete-memory.ts Outdated

Comment thread src/server/highlights/toggle.ts Outdated

nonnil added 6 commits May 16, 2026 20:43

merge workflow18 product language plan

6e2e7af

feat: migrate product language to flashbacks and moments

0b17eb0

fix: refine flashback navigation language

7527c96

fix: use paint tool icon for theme tab

0643392

fix: refine paint tool icon

39281d7

fix: align theme nav icon scale

5142a6d

chatgpt-codex-connector Bot reviewed May 17, 2026

View reviewed changes

Comment thread src/server/memories/delete-memory.ts

Comment thread src/server/backup/index.ts Outdated

Comment thread src/server/reader/markdown-renderer.ts Outdated

fix: address backup and reader review followups

c53b1b1

Copilot started work on behalf of nonnil May 17, 2026 20:41 View session

Copilot finished work on behalf of nonnil May 17, 2026 20:42

chatgpt-codex-connector Bot reviewed May 17, 2026

View reviewed changes

Comment thread extensions/browser/src/capture.ts

Comment thread src/server/db/repositories.ts Outdated

Comment thread src/routes/api/memories/[memoryId].ts Outdated

fix: keep tag API helpers in server route build

d6c69ca

Copilot started work on behalf of nonnil May 17, 2026 21:40 View session

Copilot finished work on behalf of nonnil May 17, 2026 21:41

fix: address memory action review feedback

71ff5aa

Copilot started work on behalf of nonnil May 17, 2026 22:42 View session

Copilot finished work on behalf of nonnil May 17, 2026 22:43

nonnil commented May 17, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed May 17, 2026

View reviewed changes

Comment thread src/server/memories/delete-memory.ts

fix: preserve content before memory delete backup

28818b6

Copilot started work on behalf of nonnil May 17, 2026 23:08 View session

Copilot finished work on behalf of nonnil May 17, 2026 23:09

nonnil self-assigned this May 17, 2026

nonnil merged commit b421a28 into workflow18-read-status May 17, 2026
2 checks passed

nonnil deleted the feat/task-18-memory-actions branch May 19, 2026 20:57

Conversation

nonnil commented May 15, 2026

Summary

Verification

Notes

Uh oh!

coderabbitai Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nonnil commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nonnil commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 17, 2026

Uh oh!

nonnil commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026

Uh oh!

nonnil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented May 15, 2026 •

edited

Loading