fix configuration key for certificates#5
Merged
hawkowl merged 2 commits intohawkowl:masterfrom Nov 13, 2016
Merged
Conversation
With the previously documented configuration, the server would silently start up without listening for https, because the "certificates" key wasn't found. This explains more clearly that it should be the name of a directory, and uses the correct configuration key name.
apparently "certificates" needs to be a single path segment next to `rproxy.ini`, so path separators are bad
Owner
|
Backwards compatibility tho :( |
Contributor
Author
|
@hawkowl Uh… this is perfectly backwards compatible. It's just a doc change. |
Contributor
Author
|
The previous docs did not correctly describe the behavior. If you used the example configuration file it would fail with a traceback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the previously documented configuration, the server would silently start up without listening for https, because the "certificates" key wasn't found. This explains more clearly that it should be the name of a directory, and uses the correct configuration key name.