Skip to content

Add support for updating group trigger dampening in Hawkular Alerts #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burmanm merged 1 commit into from
Jan 22, 2017
Merged

Add support for updating group trigger dampening in Hawkular Alerts #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions hawkular/alerts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,17 @@ def create_group_dampening(self, group_id, dampening):
url = self._service_url(['triggers', 'groups', group_id, 'dampenings'])
return Dampening(self._post(url, data))

def update_group_dampening(self, group_id, dampening_id, dampening):
"""
Update an existing group dampening
:param group_id: Group Trigger id attached to dampening
:param dampening_id: id of the dampening to be updated
:return: Group Dampening created
"""
data = self._serialize_object(dampening)
url = self._service_url(['triggers', 'groups', group_id, 'dampenings', dampening_id])
return Dampening(self._put(url, data))

def delete_group_dampening(self, group_id, dampening_id):
"""
Delete an existing group dampening
Expand Down
21 changes: 15 additions & 6 deletions tests/test_alerts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,9 @@ def test_create_groups(self):
m1.data_id_map = {'my-metric-id': 'my-metric-id-member1'}

dampening = Dampening()
dampening.dampening_id = 'a-group-dampening'
dampening.trigger_mode = TriggerMode.FIRING
dampening.type = DampeningType.STRICT
dampening.trigger_id = 'a-group-trigger'

tc = self.client.create_group_trigger(t)
self.assertEqual(tc.type, TriggerType.GROUP)
Expand All @@ -230,15 +230,24 @@ def test_create_groups(self):
gm = self.client.get_group_members('a-group-trigger')
self.assertEqual(len(gm), 1)
self.assertEqual(gm[0].id, 'member1')

# Create group trigger dampening
self.client.create_group_dampening('a-group-trigger', dampening)
gt = self.client.get_trigger('a-group-trigger', full=True)
gd = gt.dampenings
self.assertEqual(len(gd), 1)
self.assertEqual(gd[0].trigger_mode, 'FIRING')
self.assertEqual(gd[0].type, 'STRICT')
gds = gt.dampenings
self.assertEqual(len(gds), 1)
self.assertEqual(gds[0].trigger_mode, 'FIRING')
self.assertEqual(gds[0].type, 'STRICT')

# Update group trigger dampening
dampening.type = DampeningType.STRICT_TIME
dampening.eval_time_setting = 5
dampening.dampening_id = gds[0].dampening_id
gd = self.client.update_group_dampening('a-group-trigger', dampening.dampening_id, dampening)
self.assertEqual(gd.type, 'STRICT_TIME')

# Delete group trigger dampening
self.client.delete_group_dampening('a-group-trigger', gd[0].dampening_id)
self.client.delete_group_dampening('a-group-trigger', dampening.dampening_id)
gt = self.client.get_trigger('a-group-trigger', full=True)
self.assertFalse(gt.dampenings)

Expand Down