Making sure we compare 2 strings and not symbol with string. #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Jiri-Kremser could you rebase? some errors are because the tests ran before the agent finished. |
jkremser
force-pushed
the
operations-symbols
branch
from
9be3b09 to
3289064
Compare
If the operation is called with the operation name given by symbol, instead of the string. It's performed correctly on the agent, but the failure callback is called.
jkremser
force-pushed
the
operations-symbols
branch
from
3289064 to
49fc84a
Compare
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue: https://bugzilla.redhat.com/show_bug.cgi?id=1391694#c5
If the operation is called like this (the operation name is given by a symbol and not as a string), it is performed correctly, but the error call back is called.