Skip to content

Making sure we compare 2 strings and not symbol with string. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Making sure we compare 2 strings and not symbol with string. #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hawkularclient.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ Gem::Specification.new do |gem|
gem.add_development_dependency('rubocop', '= 0.34.2')
gem.add_development_dependency('coveralls')
gem.add_development_dependency('rack', '~> 1.6.4')
gem.add_development_dependency('pry-byebug')

gem.rdoc_options << '--title' << gem.name <<
'--main' << 'README.rdoc' << '--line-numbers' << '--inline-source'
Expand Down
3 changes: 2 additions & 1 deletion lib/hawkular/operations/operations_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,8 @@ def handle_message(operation_name, operation_payload, &callback)
when "#{operation_name}Response"
same_path = parsed[:data]['resourcePath'] == operation_payload[:resourcePath]
# failed operations don't return the operation name from some strange reason
same_name = parsed[:data]['operationName'] == operation_payload[:operationName]
same_name = operation_payload[:operationName].nil? ||
parsed[:data]['operationName'] == operation_payload[:operationName].to_s
if same_path # using the resource path as a correlation id
success = same_name && parsed[:data]['status'] == 'OK'
success ? callback.perform(:success, parsed[:data]) : callback.perform(:failure, parsed[:data]['message'])
Expand Down