Migrate get-tag-name to docker-actions#46
Merged
JackPGreen merged 2 commits intomasterfrom Feb 9, 2026
Merged
Conversation
nishaatr
requested changes
Feb 6, 2026
Contributor
nishaatr
left a comment
nishaatr
left a comment
There was a problem hiding this comment.
needs usual unit test
feels an overkill !!
Contributor
Author
Pointless but added a (trivial) one. |
|
nishaatr
requested changes
Feb 9, 2026
| - name: Run get-tag-name | ||
| uses: ./get-tag-name | ||
| with: | ||
| VERSION: "5.4.1" |
Contributor
There was a problem hiding this comment.
why not test output is v5.4.1?
Contributor
Author
There was a problem hiding this comment.
why not test output is
v5.4.1?
I could do but seems complete overkill.
Replacing one duplicated inlineable operation (prepending "v" to a variable) becomes >30 LOC.
nishaatr
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See hazelcast/hazelcast-docker#1227