Windows builds fail on client shutdown

[ihsandemir]

Windows tests sometimes fail due to memory access during client shutdown. The problem is isolated down to ClusterService shutdown and particularly to the deletion of the cluster listener thread. With some added logs we see the following:

12:09:20 Dec 19, 2017 09:09:16 AM INFO: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] LifecycleService::LifecycleEvent SHUTTING_DOWN
12:09:20 Dec 19, 2017 09:09:16 AM INFO: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] Shutting down InvocationService
12:09:20 Dec 19, 2017 09:09:16 AM INFO: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] Shutting down ConnectionManager
12:09:20 Dec 19, 2017 09:09:16 AM WARNING: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] Closing connection (id:2) to Address[127.0.0.1:5702] with socket id 144. Hazelcast client is shutting down
12:09:20 Dec 19, 2017 09:09:16 AM WARNING: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] Closing connection (id:3) to Address[127.0.0.1:5701] with socket id 160. Hazelcast client is shutting down
12:09:20 Dec 19, 2017 09:09:16 AM WARNING: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] Closing connection (id:1) to Address[127.0.0.1:5701] with socket id 340 as the owner connection.Closing owner connection to Address[127.0.0.1:5701]
12:09:20 Dec 19, 2017 09:09:16 AM WARNING: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [448] hz.heartbeater is cancelled
12:09:20 Dec 19, 2017 09:09:16 AM INFO: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] Shutting down PartitionService
12:09:20 Dec 19, 2017 09:09:16 AM INFO: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] Shutting down ClusterService
12:09:20 Dec 19, 2017 09:09:16 AM INFO: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] ClusterListenerThread::stop: Started
12:09:20 Dec 19, 2017 09:09:16 AM INFO: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] ClusterListenerThread::stop: Decremented startLatch
12:09:20 Dec 19, 2017 09:09:16 AM INFO: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] ClusterListenerThread::stop: Closing cluster connection
12:09:20 Dec 19, 2017 09:09:16 AM INFO: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] ClusterListenerThread::stop: Resetting cluster connection pointer
12:09:20 Dec 19, 2017 09:09:16 AM INFO: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] LifecycleService::LifecycleEvent CLIENT_DISCONNECTED
12:09:20 Dec 19, 2017 09:09:16 AM INFO: [HazelcastCppClient3.9.1-SNAPSHOT] [dev] [5024] ClusterListenerThread::stop: Deleting cluster worker thread
12:09:30 Process leaked file descriptors. See https://jenkins.io/redirect/troubleshooting/process-leaked-file-descriptors for more information
12:09:30 Build step 'Execute Windows batch command' marked build as failure