Put the test header after the boost includes to solve with SSL=OFF at Windows [HZ-5198 ] #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oblem with SSL=OFF.
…ions such as boost 1.73.0 since otherwise it tries to build for mcvc-6.0 and fails. E.g.: ``` ...skipped <pbin.v2\libs\chrono\build\msvc-6.0\release\address-model-32\link-static\threading-multi>chrono.obj for lack of <pbin.v2\standalone\msvc\msvc-6.0>msvc-setup.nup... ```
yuce
approved these changes
Oct 27, 2025
JackPGreen
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the test header after the boost includes. Solves windows build problem with SSL=OFF.
fixes #1328
fixes HZ-5198
With the new Visual studio version, only Boost 1.80.0 and later can compile. Hence, changed the minimum tested boost version for Windows to 1.80.0 for windows nightly tests. Trying to test older Boost version than 1.80.0 on windows should not be needed unless a specific ask from a user. This should be acceptable since we still test older Boost version(1.73.0) at Linux anyway.
Re-enabled the WITH_OPENSSL=OFF builds of windows for the PR builder.
See an example test run as green in this build (had to use branch run due to workflow change).