32-bit compilation using gcc 4.1.2 causes non-virtual destructor and ‘int’ over ‘long int’ usage warnings #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting in DefaultNearCache so that there is no warning at 32-bit compiler.
Contributor
|
Test PASSed. |
sancar
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the missing virtual destructors. Changed exception string formatting in DefaultNearCache so that there is no warning at 32-bit compiler.
When compiled using gcc 4.8.1 the compilation produces the following warnings:
KeyStateMarker.h:46: warning: ‘class hazelcast::client::map::impl::nearcache::KeyStateMarker’ has virtual functions but non-virtual destructor
DefaultNearCache.h:154: warning: passing ‘hazelcast::client::config::InMemoryFormat’ chooses ‘int’ over ‘long int’