Changed closedTime to closedTimeDuration to support correct atomic initialization #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Additional casts are proposed in this PR, is it suitable? |
Contributor
|
Can one of the admins verify this patch? |
1 similar comment
Contributor
|
Can one of the admins verify this patch? |
ihsandemir
previously approved these changes
May 8, 2020
Collaborator
There was a problem hiding this comment.
Looks good, but we have one more place we use similar atomic at here: https://github.com/hazelcast/hazelcast-cpp-client/blob/master/hazelcast/include/hazelcast/client/connection/ReadHandler.h#L63
We need a similar change for this as well. Can you add it to this PR?
Collaborator
|
verify-linux |
Contributor
|
Linux test FAILed. |
Collaborator
|
@RikeVoltz aws windows machine related test failures, other tests passed. it will be ok when windows build is up and running. |
ihsandemir
approved these changes
May 8, 2020
Collaborator
|
verify |
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test FAILed. |
Collaborator
|
verify-windows |
Contributor
|
Windows test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #592, the idea of fix is taken from this answer