Logger enhancements #688
Merged
Logger enhancements #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihsandemir
reviewed
Nov 13, 2020
| } | ||
|
|
||
| namespace { | ||
|
|
Collaborator
There was a problem hiding this comment.
can we just utilize utilities from boost and not have an extra method? did you check boost? e.g. https://stackoverflow.com/questions/2492775/get-local-time-with-boost The boost::posix_time::second_clock::local_time() uses localtime_r
Collaborator
There was a problem hiding this comment.
We decided to do this later before 4.0 release. An issue will be opened for this.
ihsandemir
reviewed
Nov 13, 2020
Contributor
|
Windows test PASSed. |
Contributor
|
Linux test PASSed. |
Contributor
|
Linux test PASSed. |
ihsandemir
approved these changes
Nov 13, 2020
Collaborator
ihsandemir
left a comment
ihsandemir
left a comment
There was a problem hiding this comment.
Once the issue is opened for localtime all is OK.
Contributor
|
Windows test PASSed. |
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test PASSed. |
Collaborator
|
related to #692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some enhancements for the logging implementation:
client::version()API instead of theHAZELCAST_VERSIONmacro in the default formatter. Fixes Logging comment #682.logger.hlocaltime. It is not guaranteed to be thread-safe. Instead, uselocaltime_sorlocaltime_rdepending on the platform.