Added the git commit date and commit id to the client starting log. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example new log: Apr 21, 2016 01:42:16 PM INFO: [HazelcastCppClient3.7-SNAPSHOT] [dev] [4298317824] (2016-04-06:0ef9654) LifecycleService::LifecycleEvent STARTING
sancar
force-pushed
the
ench/logGitInfo/master
branch
from
2a3ac61 to
794342d
Compare
Contributor
|
Test PASSed. |
| logger.info("LifecycleService::LifecycleEvent STARTING"); | ||
| { | ||
| char msg[100]; | ||
| util::snprintf(msg, 100, "(%s:%s) LifecycleService::LifecycleEvent STARTING", HAZELCAST_GIT_COMMIT_DATE, HAZELCAST_GIT_COMMIT_ID); |
Collaborator
There was a problem hiding this comment.
Is the date format as YYYYMMDD? PRD wants it this way. You can just convert it. See https://github.com/hazelcast/hazelcast-cpp-client/pull/90/files#diff-25e2207206ddcc5a7f4063ce1e5c2853R94
Contributor
Author
There was a problem hiding this comment.
I did not think it as a strong requirement. And adding code just for that seemed unnecessary to me. That is why I leave it that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example new log:
Apr 21, 2016 01:42:16 PM INFO: [HazelcastCppClient3.7-SNAPSHOT] [dev] [4298317824] (2016-04-06:0ef9654) LifecycleService::LifecycleEvent STARTING