Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow empty memberlist on cluster id changes[API-1590] #1452

Merged
merged 771 commits into from
Dec 30, 2022
Merged

Don't allow empty memberlist on cluster id changes[API-1590] #1452

merged 771 commits into from
Dec 30, 2022

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Dec 30, 2022

Superseeds #1448

srknzl and others added 30 commits July 30, 2021 10:32
@srknzl
Update dependencies (hazelcast#987)
1b4a388
@srknzl
Remove broken anchors (hazelcast#993)
1396db0
@srknzl
Update dependencies (hazelcast#998)
35ac7a3
@srknzl
Add version check to dateTimeUtil (hazelcast#999)
b9229cb
@srknzl
Add getConnectionForSql and use it (hazelcast#988)
ea7a8fb
@srknzl
Fail fast on failover wrong key and add tests (hazelcast#977)
f9ae3e0
@srknzl
API-543 Add bigint serializer (hazelcast#975)
fed2386
@srknzl
API-579 Add code samples for decimal and date/time classes usage (haz…
b359b88 
…elcast#973)
@srknzl
API-657 GH actions (hazelcast#978)
1911b61
@srknzl
Update ttl values to fix flaky tests (hazelcast#1002)
32382e9
@srknzl
Update dependencies (hazelcast#1013)
d5cc70c
@srknzl
API-664 Add code sample checker (hazelcast#989)
18e3b36 
* Add code sample checker

* Update code samples to add client.shutdown
@srknzl
Make dependabot monthly (hazelcast#1014)
6286c85
@srknzl
Delete Object.setPrototypeOf calls in HazelcastErrors (hazelcast#1005)
ea313be
@srknzl
Fix tests and code samples (hazelcast#1020)
55bf59d
@alisengul53
Codecov report upload step is added (hazelcast#1019)
4965cf5
@srknzl
Return same promise for multiple shutdown calls (hazelcast#1003)
e9b3d45
@srknzl
API-668 Document and Validate Properties (hazelcast#1001)
0c7bbf8
@srknzl
API-676 Implement distinct aggregator (hazelcast#1007)
5f75236 
* Add distinct aggregator and tests

* Update documentation
@srknzl
Fix DistributedObjectsTest and HazelcastClientTest failures due to in…
a53d292 
…ternal proxies (hazelcast#1023)

* Fix DistributedObjectsTest failure due to internal proxies

* Fix HazelcastClientTest
@srknzl
Rename json to json-flat (hazelcast#1025)
d5decdc
@srknzl
Fix sql tests and code samples (hazelcast#1034)
b9dcbc8 
* Test adjustments around jet enabled config for backward compatbility tests

* Fix datatypetest.js

* Move createMapping to TestUtil and use it in all sql integration tests

* Fix code samples
@srknzl
Update dependencies (hazelcast#1035)
9f7effe
@srknzl
Add paging predicate sample (hazelcast#1000)
266ab50
@srknzl
API-673 HeartbeatfromServer flaky test fix (hazelcast#1006)
f8a36a5 
* Make membership listener's methods optionsl in interface
@srknzl
Make codecov informational (hazelcast#1026)
18c9a28
@srknzl
Make codecov patch informational (hazelcast#1039)
d104ca5
@srknzl
Eslint config changes (hazelcast#1036)
acbd748 
* Add ignorePatterns for IDEs that give warning

* Merge eslint configs

* Add eslint config file for user code
@srknzl @mdumandag
Add markdown linter API-869 (hazelcast#1040)
372bdc7 
* Add markdown linter

* Update DOCUMENTATION.md

Co-authored-by: Metin Dumandag <metindumandag@gmail.com>

* Add md001 and md040 and refactor

* Add lint-markdown:fix and fix header in documentation.md

Co-authored-by: Metin Dumandag <metindumandag@gmail.com>
@srknzl
Update unisocket mode docs (hazelcast#1042)
6a9f8cb
harunalpak and others added 20 commits December 13, 2022 10:57
@harunalpak
Fix nightly runner workflow
ab0d337
@harunalpak
For windows GITHUB_WORKSPACE not working. Replaced $GITHUB_WORKSPACE …
099c53a 
…=> ${{ github.workspace }}
@harunalpak
Updating coverage_runner.yml
d33cdbd
@harunalpak
Merge remote-tracking branch 'upstream/master'
cf72c26
@harunalpak
Merge branch 'master' of https://github.com/harunalpak/hazelcast-node…
8100729 
…js-client
@harunalpak
Merge remote-tracking branch 'upstream/master'
0f4a528
@harunalpak
Merge remote-tracking branch 'upstream/master'
9f39812
@harunalpak
Merge remote-tracking branch 'upstream/master'
4f2e955
@harunalpak
Don't allow empty memberlist on cluster id changes
4527a1d
@harunalpak
Fix relate to handleMembersViewEvent
8054572
@harunalpak
Bug fixed
c19b9c3
@harunalpak
Change the expected memberId
f74a061
@harunalpak
Remove unnecessary code part
9de2a0d
@harunalpak
One of the java test ported
f823ecc
@harunalpak
Java tests were ported.
820380e
@harunalpak
unused code removed
e7fe630
@harunalpak
Fixes related to PR comments.
e8916ae
@harunalpak
Fix related to PR comments
5651891
@harunalpak
Fix related to comments
725bb49
@srknzl
Fix test
2c1c218
@srknzl srknzl added this to the 5.3.0 milestone Dec 30, 2022
@srknzl srknzl mentioned this pull request Dec 30, 2022
Closed
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #1452 (2c1c218) into master (895b041) will increase coverage by 0.06%.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
+ Coverage   93.39%   93.46%   +0.06%     
==========================================
  Files         466      466              
  Lines       16622    16628       +6     
  Branches     1350     1350              
==========================================
+ Hits        15524    15541      +17     
+ Misses        800      792       -8     
+ Partials      298      295       -3
Impacted Files Coverage Δ
src/invocation/ClusterService.ts 97.36% <96.29%> (+2.49%) ⬆️
src/HazelcastClient.ts 93.44% <100.00%> (ø)
src/core/MembershipListener.ts 100.00% <100.00%> (ø)
src/listener/ClusterViewListenerService.ts 100.00% <100.00%> (ø)
src/network/Connection.ts 95.72% <100.00%> (+0.89%) ⬆️
src/network/ConnectionManager.ts 85.35% <100.00%> (+1.36%) ⬆️
src/proxy/MultiMapProxy.ts 98.46% <0.00%> (-0.52%) ⬇️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@srknzl srknzl merged commit 95754b5 into hazelcast:master Dec 30, 2022
@srknzl srknzl mentioned this pull request Feb 20, 2023
Closed
6 tasks
srknzl added a commit to fatihozer0/hazelcast-nodejs-client that referenced this pull request Mar 24, 2023
@srknzl
Don't allow empty memberlist on cluster id changes[API-1590] (hazelca…
c61262e 
…st#1452)

Port of hazelcast/hazelcast#20818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdumandag mdumandag mdumandag approved these changes

Assignees
No one assigned
Labels
Source: Internal Type: Enhancement
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
8 participants
@srknzl @mdumandag @alisengul53 @devOpsHazelcast @degerhz @fatihozer0 @mehmettokgoz @harunalpak