Remove getOrConnectToMember assertion because it is also called by triggerClusterReconnection #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iggerClusterReconnection
mdumandag
approved these changes
Jun 13, 2023
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
+ Coverage 93.42% 93.45% +0.03%
==========================================
Files 466 466
Lines 16628 16628
Branches 1350 1350
==========================================
+ Hits 15535 15540 +5
+ Misses 798 794 -4
+ Partials 295 294 -1 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is added after reflecting this change to java https://github.com/hazelcast/hazelcast/pull/21705/files.
as can be seen, in this change, we are only changing the smart client reconnection task's logic. It should not call getOrConnectToMember. However, in the node.js test we added an assertion that checks that getOrConnectToMember should not be called at all. First of all, this logic does not exist in the java test and second, triggerClusterReconnection will also call getOrConnectToMember. Therefore, our assertion is not correct. I removed it.
related node.js backw compatiblity test: https://github.com/hazelcast/client-compatibility-suites/actions/runs/5253301597/jobs/9490454007