Fix lock timeout behaviour of when key owner is gone #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Python 2.7 Tests FAILed. |
Contributor
|
Python 3.7 Tests FAILed. |
mdumandag
force-pushed
the
fix-lock-timeout-behaviour
branch
from
2eaaf68 to
e4e9b52
Compare
Contributor
|
Python 2.7 Tests FAILed. |
Contributor
|
Python 3.7 Tests FAILed. |
mdumandag
force-pushed
the
fix-lock-timeout-behaviour
branch
from
e4e9b52 to
82b4d39
Compare
Contributor
|
Python 3.7 Tests FAILed. |
Contributor
|
Python 2.7 Tests FAILed. |
mdumandag
force-pushed
the
fix-lock-timeout-behaviour
branch
from
82b4d39 to
7249aac
Compare
Contributor
|
Python 2.7 Tests FAILed. |
Contributor
|
Python 3.7 Tests FAILed. |
mdumandag
force-pushed
the
fix-lock-timeout-behaviour
branch
from
7249aac to
12fd1f5
Compare
Contributor
|
Python 3.7 Tests FAILed. |
Contributor
|
Python 2.7 Tests FAILed. |
mdumandag
force-pushed
the
fix-lock-timeout-behaviour
branch
from
12fd1f5 to
897b162
Compare
Contributor
|
Python 3.7 Tests FAILed. |
Contributor
|
Python 2.7 Tests FAILed. |
mdumandag
force-pushed
the
fix-lock-timeout-behaviour
branch
from
897b162 to
139c2c3
Compare
Contributor
|
Python 3.7 Tests FAILed. |
Contributor
|
Python 2.7 Tests FAILed. |
mdumandag
force-pushed
the
fix-lock-timeout-behaviour
branch
from
139c2c3 to
8086ef7
Compare
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
sancar
approved these changes
Sep 24, 2018
mdumandag
force-pushed
the
fix-lock-timeout-behaviour
branch
from
8086ef7 to
dac8559
Compare
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
mdumandag
force-pushed
the
fix-lock-timeout-behaviour
branch
from
dac8559 to
51846b9
Compare
SaitTalhaNisanci
approved these changes
Sep 25, 2018
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests FAILed. |
mdumandag
force-pushed
the
fix-lock-timeout-behaviour
branch
from
51846b9 to
6d90c08
Compare
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
mdumandag
force-pushed
the
fix-lock-timeout-behaviour
branch
from
6d90c08 to
63cc475
Compare
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client waiting on lock to get it, if the member that it is waiting on shuts down/terminated , client retries it on new owner of the lock.
If a client waits for longer than client.invocation.timeout.seconds, when exception came from server, it is wrapped inside OperationTimeoutException and thrown to user.
This pr changes this behaviour so that waiting lock operations (map.lock/try_lock lock.lock/try_lock) will not throw exception but retry the operation.
fixes #107