Fix heartbeat test that fails on Windows #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heartbeat test was failing on windows because while connecting to the second member that was created recently, member was throwing HazelcastInstanceNotActive exception during the client authentication process. With this fix, client will try to connect to the second member and if an exception occurs, it will sleep for a while and try again up to 3 times.
Contributor
Author
|
verify |
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
1 similar comment
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
Contributor
|
Python 2.7 Tests PASSed. |
mdumandag
force-pushed
the
fixHeartbeatTest
branch
from
0c292ee to
7fe2062
Compare
Contributor
|
Python 2.7 Tests PASSed. |
Contributor
|
Python 3.7 Tests PASSed. |
sancar
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heartbeat test was failing on windows because
while connecting to the second member that
was created recently, member was throwing
HazelcastInstanceNotActiveException during
the client authentication process. With this fix,
client will try to connect to the second member
and if an exception occurs, it will sleep
for a while and try again up to 3 times.
fixes #138