let the python handle the loop while reading a byte array #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were looping over the result to convert the byte array into a list. This was causing a huge latency problem when the result we iterate over is huge. With this change, the conversion is delegated to python itself.
By the way,
read_byte_arraymethod returns list of byte sized integers, not a byte array. I think we can just return theresultwithout converting it to a list sincebytearrayis special type in python. If we do that, we can also change theread_utfmethod to something like this as we did in the Node.js clientThis
read_utfchange solves the issue described in #149. The duration of the string read test described in the issue goes from 35 seconds to 100-200 milliseconds in my laptop.